Upgrade site Next.js version with Babel and TypeScript#848
Draft
rafaell-lycan wants to merge 1 commit intogeist-org:masterfrom
Draft
Upgrade site Next.js version with Babel and TypeScript#848rafaell-lycan wants to merge 1 commit intogeist-org:masterfrom
rafaell-lycan wants to merge 1 commit intogeist-org:masterfrom
Conversation
❌ Deploy Preview for geist-ui failed.
|
Author
|
Hi y'all 👋 First of all, this is a draft, and the goal here is just to share an issue I've found before splitting it into smaller commits. I've found 2 TS issues when generating types with
For the first issue I have no clue on how to bypass that TS error without adding a The second issue can be fixed by simply wrapping it onto an object and spreading it after props, but I haven't included on this PR yet because I want to see if anyone can bring a better alternative. return React.cloneElement(children, {
...props,
...{ className: `${children.props.className} ${className} ${classes}` },
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Change information
Update the Next.js version from
12.0.9-canary.0to12.3.4and also some small changes on the following packages:@babel/*is now using7.23.xwith exception of@babel/preset-react(7.22.15);@mapbox/rehype-prismis now using0.8.0which also update its dependencies;@next/mdxis now using the latest12.xversion compatible with Next.js v12;typescriptis now using the latest v4 version which requires upgradingttypescript;extract-mdx-metadatais now using v2 which brings a series of security fixes;fs-extrais now using v11 which drops Node.js v12 and brings better compatibility with TS;@types/react-*is now using the latest version under v17;NOTE: During the TypeScript upgrade, some types have gotten errors and were updated.