This repository was archived by the owner on Jun 5, 2021. It is now read-only.
Add GENDIR directory to custom resolvers#53
Draft
josefermin wants to merge 2 commits intofwouts:masterfrom
Draft
Add GENDIR directory to custom resolvers#53josefermin wants to merge 2 commits intofwouts:masterfrom
josefermin wants to merge 2 commits intofwouts:masterfrom
Conversation
|
|
fwouts
suggested changes
Apr 24, 2019
|
|
||
| const base = path.join(process.cwd(), sourceDir) | ||
| const gendir = path.join(base, process.env["GENDIR"], '..', 'bin') | ||
| const gendir2 = path.join(base, process.env["GENDIR"]) |
Owner
There was a problem hiding this comment.
I wonder if we should instead simply update gendir by removing '..', 'bin'?
If we indeed need both, then it would be worth renaming each to better represent what it's used for, and add a comment with an example where it would be necessary.
Bonus points if you add an example running in CI that highlights the need for this 😅
Currently devserver is not working becuase the env var GENDIR is not passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.