This repository was archived by the owner on Jun 9, 2022. It is now read-only.
Try to fix negative event.timeStamp values on iOS 11.3/4#564
Open
gwynjudd wants to merge 6 commits intoftlabs:mainfrom
Open
Try to fix negative event.timeStamp values on iOS 11.3/4#564gwynjudd wants to merge 6 commits intoftlabs:mainfrom
gwynjudd wants to merge 6 commits intoftlabs:mainfrom
Conversation
…ly for iOS 11.3, so that other platforms will not be affected.
…lues. Use onTouchEnd timestamp source based on onTouchStart timestamp source.
Not sure what effect this would have
Author
Author
|
Just putting this out there as a potential fix. The change in #550 still seems to cause the issue for some situations so if people could try this out and report back success/fail |
|
@gwynjudd Have just tried your PR and it seems to work well for me. The other ones didn't - using iOS 11.4. |
Author
|
We went live with this change a month ago now, no reports of further issues |
|
Yes, I have tried #550 ,but it still cause the issue for some situations. Hope this can completely fix the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is the same as #550, but uses Date.getTime() for all touchstart/end events instead of just ones where the timestamp was negative.