This repository was archived by the owner on Jun 9, 2022. It is now read-only.
Open
Conversation
Author
|
Note that I haven't tested this yet - just wanted to propose a simple possible fix. |
If the page author has set an explicit `touch-action` on the layer via CSS (eg. `pan-y` for an image carousel), then don't override that.
|
This fix worked to resolve a bug I was experiencing with iOS Safari 9.1 and above, since the 350ms delay was removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the browser supports
touch-actionthen disable the tap delay explicitly by disabling the double-tap-to-zoom gesture and not installing touch listeners at all.Setting
touch-actiontomanipulationon an element (when not already set to something else) has no other impact than disabling double-tap (which normal FastClick code does anyway), so there shouldn't be much (any?) downside to this approach. It has several advantages to the existing behavior:Fixes #498