Skip to content

trim docker container and add teardown logs#302

Merged
fslabs-bot[bot] merged 1 commit intomainfrom
ad/docker
Mar 6, 2026
Merged

trim docker container and add teardown logs#302
fslabs-bot[bot] merged 1 commit intomainfrom
ad/docker

Conversation

@atlv24
Copy link
Copy Markdown
Contributor

@atlv24 atlv24 commented Mar 6, 2026

let docker allocate ports to avoid a toctou bug between free_local_port() finding an available port and docker run binding to it, also trim the trailing newline from container id and log teardown errors for better visibility

@fslabs-bot fslabs-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 6, 2026
@fslabs-bot fslabs-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2026
@atlv24 atlv24 changed the title improve docker port handling trim docker container and add teardown logs Mar 6, 2026
@fslabs-bot
Copy link
Copy Markdown

fslabs-bot bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: loispostula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fslabs-bot fslabs-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2026
@fslabs-bot fslabs-bot bot merged commit be2bacc into main Mar 6, 2026
2 checks passed
@fslabs-bot fslabs-bot bot deleted the ad/docker branch March 6, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants