Merged
Conversation
fslabs-bot
bot
added
the
size/M
Merged
loispostula
approved these changes
Mar 6, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: loispostula The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fslabs-bot
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CrateGraph::new_recursive was using the directory where a Cargo.toml was found as the workspace path. When a crate is a member of a parent workspace, cargo metadata resolves the workspace root to the parent — but the workspace entry was still created at the member's path. This caused fix-lock-files --check to look for Cargo.lock in member directories instead of the actual workspace root, producing false "out of sync" errors for lock files that don't (and shouldn't) exist.
Now uses metadata.workspace_root as the workspace path, deduplicates entries that resolve to the same root, and tracks lock file side effects at the correct path.