Open
Conversation
|
akhilnarang
reviewed
Oct 7, 2025
Member
akhilnarang
left a comment
There was a problem hiding this comment.
While its fine overall, "default app" sounds weird. Maybe can tweak that flag name.
Also I've noticed many of the apps READMEs had mentioned using yarn, here npm is hardcoded.
I'd prefer adding in some parameter which basically lets you specify a service name + command, and that would get added to procfile/mprocs yaml as chosen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Adds two configuration options to
bench init:--use-mprocs: allows people to usemprocsinstead of ofhoncho- though both are still supported even with this option--default-app TEXT: allows developers to set a default app to run the frontend server forbench startwill now usemprocsifmprocs.yamlexists - otherwise it'll use honcho (current working).Also, if
default-appis specified, bothuse_mprocsandinstall-appare assumed so that this:becomes: