Skip to content

Comments

feat: integrate mprocs#1662

Open
safwansamsudeen wants to merge 2 commits intodevelopfrom
mprocs
Open

feat: integrate mprocs#1662
safwansamsudeen wants to merge 2 commits intodevelopfrom
mprocs

Conversation

@safwansamsudeen
Copy link

@safwansamsudeen safwansamsudeen commented Oct 6, 2025

Adds two configuration options to bench init:

  • --use-mprocs: allows people to use mprocs instead of of honcho - though both are still supported even with this option
  • --default-app TEXT: allows developers to set a default app to run the frontend server for

bench start will now use mprocs if mprocs.yaml exists - otherwise it'll use honcho (current working).

Also, if default-app is specified, both use_mprocs and install-app are assumed so that this:

bench init --use-mprocs --install-app drive --default-app drive PATH

becomes:

bench init --default-app drive PATH

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

Copy link
Member

@akhilnarang akhilnarang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While its fine overall, "default app" sounds weird. Maybe can tweak that flag name.

Also I've noticed many of the apps READMEs had mentioned using yarn, here npm is hardcoded.

I'd prefer adding in some parameter which basically lets you specify a service name + command, and that would get added to procfile/mprocs yaml as chosen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants