Adapter improvements

[gr0uch]

Some incremental improvements to the Adapter:

• Logical operators in find (Adapter find options additions  #186).
• Add support for singular IDs, just a small opt-in improvement to aid usability. no longer needed due to new instance methods.
• Add support for update & delete queries.

Regarding the last point, it could be like:

adapter.update(type, [ {
  // If ID is missing, expect options.
  options: {
    // Re-use `find` method options.
  },
  replace: { ... },
  push: { ... },
  pull: { ... },
  operate: { ... }
} ])

Delete API:

adapter.delete(type, [ {
  // Re-use `find` method options.
} ])

[voronianski]

@daliwali there are not so many information about push and pull objects in update. They are used only in updating relationships between records?

[voronianski]

@daliwali also I noticed that when doing for example PUT request, (e.g. /users/d5049d443ae685531ced3624432fc67a) input hook function is not called but response is always 204. Is it a detail of JSON API serializer? Or I should somehow manually return 404?

[gr0uch]

The input hook should always run, are you sure that record exists? Can you show me an example of that bug? You shouldn't have to manually throw a NotFoundError.

[voronianski]

@daliwali record exits, you can check this app - https://github.com/dhhb/api-next

Types look like - https://github.com/dhhb/api-next/blob/master/src/v1/types/user.js

# to run the app if you'd like
# but you'll need mongo instance running on port 27017
npm i
npm run start-dev

Input is called for POST and PATCH http methods only. On PUT it's not called and status 204 is responded.

[gr0uch]

Actually it's because PUT is not supported at all. Nowhere in the JSON API spec tells you to use the PUT method. The response status is fixed in commit fortunejs/fortune-json-api@f46dc7e and published as 2.1.1.

[voronianski]

@daliwali but is it ok that unsupported method returns 204 instead of 404?

[gr0uch]

It should return 415 Unsupported, which is the proper status code, not 404 as that would imply the URL doesn't exist.

[voronianski]

@daliwali then it's a bug?

[gr0uch]

it has already been fixed here.

[voronianski]

@daliwali thanks

[gr0uch]

Add support for update & delete queries.

Probably not going to happen anytime soon, it might be unsafe to do in application code. The motivation for this was to be able to run DB migrations but I guess this can be handled outside of Fortune.