feat (sparse): add binary operators overloading #1117
+258
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jvdp1 when I tried to recover the changes from master into the PR I lost the changes and wasn't able to directly merge. Sorry about that. I managed to recover the files from the github history and then just copy pasted the required changes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1117 +/- ##
=======================================
Coverage 68.55% 68.55%
=======================================
Files 396 396
Lines 12746 12746
Branches 1376 1376
=======================================
Hits 8738 8738
Misses 4008 4008 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(exact copy of #1082 which got closed and couldn't directly merge, had to recover by hand the changes)
This PR proposes support for binary operators
+, -, *, /for all sparse matrices defined in thestdlib_sparse_kindsmodule.purefunctionsELLandSELLCskipped because of explicit zeros causing NaNs at division)Additional fixes needed for this PR:
from_ijvfor theCSCtypecoo2cscin case of a rectangular matrix.