feat(PLAY-324): upgrade @flowplayer/player to latest canary, fix opts prop types#46
Merged
maximzavadskiy merged 14 commits intomainfrom May 10, 2024
Merged
feat(PLAY-324): upgrade @flowplayer/player to latest canary, fix opts prop types#46maximzavadskiy merged 14 commits intomainfrom
maximzavadskiy merged 14 commits intomainfrom
Conversation
maximzavadskiy
force-pushed
the
feat/PLAY-324/upgrade
branch
from
8d52dc6 to
f033636
Compare
maximzavadskiy
changed the title
maximzavadskiy
changed the title
maximzavadskiy
changed the title
br3akzero
reviewed
May 7, 2024
| title: "Example title", | ||
| description: "Example description", | ||
| poster: { }, | ||
| poster: "https://picsum.photos/200/300", |
br3akzero
reviewed
May 7, 2024
br3akzero
left a comment
br3akzero
left a comment
There was a problem hiding this comment.
Great that you added a test for this!
Contributor
Author
|
@rashadatjou good to merge? |
|
@maximzavadskiy let me test this out locally and if everything is functioning I will give you the green light |
br3akzero
approved these changes
May 9, 2024
br3akzero
left a comment
br3akzero
left a comment
There was a problem hiding this comment.
@maximzavadskiy the changes look great I just cleaned up the test/index.test-d.tsx file. This PR is good to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.