Skip to content

Conversation

@MrHDOLEK
Copy link
Contributor

@MrHDOLEK MrHDOLEK commented Oct 30, 2025

Resolves: #1926

Change Log


Added

  • TypeNarrower interface for type narrowing pattern
  • StringTypeNarrower class implementing TypeNarrower interface
  • InstanceOfTypeNarrower class for handling external UUID libraries
  • Support for detecting additional string types: boolean, integer, float, date, datetime, timezone, null

Fixed

  • Redundant InstanceOfType handling in EntryFactory::create() method
  • Missing NullType support in EntryFactory::createAs() method

Changed

  • StringTypeChecker renamed to StringTypeNarrower with new interface contract
  • Refactored EntryFactory to use modular TypeNarrower pattern
  • EntryFactory now uses InstanceOfTypeNarrower for UUID library detection
  • JsonType.isValid() method now uses StringTypeNarrower for validation

Removed

  • Duplicate UUID library detection logic from EntryFactory

Deprecated

Security

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 97.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.78%. Comparing base (7327e12) to head (94ee42f).
⚠️ Report is 6 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1943      +/-   ##
==========================================
+ Coverage   79.72%   79.78%   +0.05%     
==========================================
  Files         833      834       +1     
  Lines       24771    24779       +8     
==========================================
+ Hits        19749    19770      +21     
+ Misses       5022     5009      -13     
Components Coverage Δ
etl 88.90% <100.00%> (+0.06%) ⬆️
cli 85.96% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.39% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.68% <ø> (ø)
lib-types 89.51% <97.26%> (+0.62%) ⬆️
lib-parquet 68.35% <ø> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 89.71% <ø> (-0.47%) ⬇️
bridge-filesystem-async-aws 91.00% <ø> (ø)
bridge-filesystem-azure 89.47% <ø> (ø)
bridge-monolog-http 96.91% <ø> (ø)
bridge-openapi-specification 94.50% <ø> (ø)
symfony-http-foundation 73.17% <ø> (ø)
adapter-chartjs 86.36% <ø> (ø)
adapter-csv 89.08% <ø> (ø)
adapter-doctrine 90.97% <ø> (ø)
adapter-elasticsearch 97.17% <ø> (ø)
adapter-google-sheet 91.40% <ø> (ø)
adapter-http 60.56% <ø> (ø)
adapter-json 89.80% <ø> (ø)
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.87% <ø> (ø)
adapter-parquet 78.91% <ø> (ø)
adapter-text 88.09% <ø> (ø)
adapter-xml 83.07% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MrHDOLEK MrHDOLEK marked this pull request as ready for review November 2, 2025 21:16
@MrHDOLEK MrHDOLEK requested a review from norberttech November 2, 2025 21:19
# Conflicts:
#	src/lib/types/src/Flow/Types/Type/Native/String/StringTypeNarrower.php
#	src/lib/types/tests/Flow/Types/Tests/Unit/Type/Native/String/StringTypeCheckerTest.php
@MrHDOLEK MrHDOLEK requested a review from norberttech November 4, 2025 22:29
@norberttech
Copy link
Member

that's a solid piece of work! 💪
Even though it introduces small BC Break
I believe more predictable EntryFactory is worth it

@norberttech norberttech merged commit 29efaa1 into flow-php:1.x Nov 5, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent Behavior of EntryFactory with Uuid

2 participants