Skip to content

Conversation

@norberttech
Copy link
Member

@norberttech norberttech commented Oct 30, 2025

…e it from there

Resolves: #1939

Change Log


Added

  • Filesystem Path Option - ContentType

Fixed

  • AsyncAWSS3DestinationStream - set correct content type

Changed

  • Make Filesystem Path / Options immutable
  • Make Filesystem Path Options accept scalar types and enums only

Removed

Deprecated

Security

@norberttech norberttech linked an issue Oct 30, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.64%. Comparing base (91acbdf) to head (f652671).
⚠️ Report is 2 commits behind head on 1.x.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #1942      +/-   ##
==========================================
+ Coverage   79.54%   79.64%   +0.10%     
==========================================
  Files         831      832       +1     
  Lines       24690    24756      +66     
==========================================
+ Hits        19640    19718      +78     
+ Misses       5050     5038      -12     
Components Coverage Δ
etl 88.82% <100.00%> (ø)
cli 85.96% <ø> (ø)
lib-array-dot 95.00% <ø> (ø)
lib-azure-sdk 60.39% <ø> (ø)
lib-doctrine-dbal-bulk 95.14% <ø> (ø)
lib-filesystem 80.68% <94.28%> (+0.60%) ⬆️
lib-types 87.98% <ø> (ø)
lib-parquet 68.34% <100.00%> (ø)
lib-parquet-viewer 83.04% <ø> (ø)
lib-snappy 89.71% <ø> (-0.47%) ⬇️
bridge-filesystem-async-aws 91.00% <100.00%> (+0.83%) ⬆️
bridge-filesystem-azure 89.47% <100.00%> (ø)
bridge-monolog-http 96.91% <ø> (ø)
bridge-openapi-specification 94.50% <ø> (ø)
symfony-http-foundation 73.17% <ø> (ø)
adapter-chartjs 86.36% <66.66%> (ø)
adapter-csv 89.08% <100.00%> (+0.62%) ⬆️
adapter-doctrine 90.97% <ø> (ø)
adapter-elasticsearch 97.17% <ø> (ø)
adapter-google-sheet 91.40% <ø> (ø)
adapter-http 60.56% <ø> (ø)
adapter-json 89.80% <100.00%> (+2.06%) ⬆️
adapter-logger 83.33% <ø> (ø)
adapter-meilisearch 97.87% <ø> (ø)
adapter-parquet 78.91% <100.00%> (+0.75%) ⬆️
adapter-text 88.09% <100.00%> (+5.16%) ⬆️
adapter-xml 83.07% <100.00%> (+0.56%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@norberttech norberttech enabled auto-merge (squash) October 31, 2025 13:06
@norberttech norberttech disabled auto-merge October 31, 2025 13:15
@norberttech norberttech merged commit 3851c0a into 1.x Oct 31, 2025
18 checks passed
@norberttech norberttech deleted the 1939-bug-to_csv-inside-write-do-not-set-up-contenttype-for-s3 branch October 31, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: to_csv() inside write do not set up ContentType for S3

2 participants