Fixed calculation of definition level in Parquet DremelShredder implementation #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## 1.x #1772 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 726 726
Lines 20829 20829
=======================================
Hits 17036 17036
Misses 3793 3793
🚀 New features to boost your workflow:
|
Contributor
Flow PHP - BenchmarksResults of the benchmarks from this PR are compared with the results from 1.x branch. Extractors+-----------------------+------------------------+------+-----+-----------------+------------------+----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-----------------------+------------------------+------+-----+-----------------+------------------+----------------+
| CSVExtractorBench | bench_extract_10k | 1 | 3 | 4.871mb -0.02% | 439.868ms -0.52% | ±0.15% -66.02% |
| ExcelExtractorBench | bench_extract_10k_ods | 1 | 3 | 65.566mb -0.00% | 1.063s -1.30% | ±1.08% -8.64% |
| ExcelExtractorBench | bench_extract_10k_xlsx | 1 | 3 | 67.666mb -0.00% | 1.690s -1.21% | ±0.63% +37.20% |
| JsonExtractorBench | bench_extract_10k | 1 | 3 | 5.463mb -0.02% | 1.129s -1.68% | ±0.59% -75.86% |
| ParquetExtractorBench | bench_extract_10k | 1 | 3 | 10.670mb -0.18% | 9.280s -18.84% | ±0.45% -47.42% |
| TextExtractorBench | bench_extract_10k | 1 | 3 | 4.593mb -0.02% | 42.197ms -0.67% | ±0.34% -14.05% |
| XmlExtractorBench | bench_extract_10k | 1 | 3 | 4.579mb -0.02% | 596.856ms -1.98% | ±0.76% -14.05% |
+-----------------------+------------------------+------+-----+-----------------+------------------+----------------+
Transformers+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
| RenameEachEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 18.590mb -0.01% | 74.626ms +0.15% | ±0.21% -68.42% |
| RenameEntryTransformerBench | bench_transform_10k_rows | 1 | 3 | 123.328mb -0.00% | 68.244ms +1.59% | ±0.53% -71.93% |
+---------------------------------+--------------------------+------+-----+------------------+-----------------+----------------+
Loaders+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
| CSVLoaderBench | bench_load_10k | 1 | 3 | 62.532mb -0.00% | 83.063ms -3.16% | ±1.09% +69.91% |
| JsonLoaderBench | bench_load_10k | 1 | 3 | 80.613mb -0.00% | 100.872ms -1.64% | ±0.93% +40.50% |
| ParquetLoaderBench | bench_load_10k | 1 | 3 | 835.158mb +0.02% | 19.235s -29.39% | ±0.55% +21.91% |
| TextLoaderBench | bench_load_10k | 1 | 3 | 17.896mb -0.01% | 29.448ms -3.33% | ±0.62% +107.37% |
+--------------------+----------------+------+-----+------------------+------------------+-----------------+
Building Blocks+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 106.010mb -0.00% | 663.350ms +1.45% | ±1.85% +23.29% |
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 55.284mb -0.00% | 334.370ms +1.80% | ±0.46% +8.71% |
| EntryFactoryBench | bench_entry_factory | 1 | 3 | 14.870mb -0.01% | 70.183ms -3.34% | ±0.72% +199.02% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 42.540mb -0.00% | 404.942ms -0.16% | ±0.54% -7.02% |
| TypeDetectorBench | bench_type_detector | 1 | 3 | 11.598mb -0.01% | 82.083ms -2.36% | ±0.12% -91.40% |
| RowsBench | bench_chunk_10_on_10k | 2 | 3 | 93.481mb -0.00% | 3.949ms -4.27% | ±2.17% +37.12% |
| RowsBench | bench_diff_left_1k_on_10k | 2 | 3 | 110.851mb -0.00% | 237.407ms -0.61% | ±0.20% -66.93% |
| RowsBench | bench_diff_right_1k_on_10k | 2 | 3 | 93.571mb -0.00% | 23.709ms -3.00% | ±0.04% -96.00% |
| RowsBench | bench_drop_1k_on_10k | 2 | 3 | 94.355mb -0.00% | 1.673ms -16.66% | ±1.48% -39.06% |
| RowsBench | bench_drop_right_1k_on_10k | 2 | 3 | 94.355mb -0.00% | 1.492ms -20.20% | ±1.27% -55.93% |
| RowsBench | bench_entries_on_10k | 2 | 3 | 92.516mb -0.00% | 3.571ms -3.85% | ±2.26% -12.53% |
| RowsBench | bench_filter_on_10k | 2 | 3 | 93.045mb -0.00% | 17.448ms +14.28% | ±1.10% -11.61% |
| RowsBench | bench_find_on_10k | 2 | 3 | 93.045mb -0.00% | 17.679ms +10.88% | ±1.67% +18.36% |
| RowsBench | bench_find_one_on_10k | 10 | 3 | 91.734mb -0.00% | 1.900μs -5.00% | ±0.00% +0.00% |
| RowsBench | bench_first_on_10k | 10 | 3 | 91.734mb -0.00% | 0.400μs -20.00% | ±0.00% +0.00% |
| RowsBench | bench_flat_map_on_1k | 2 | 3 | 100.794mb -0.00% | 14.737ms -8.08% | ±1.03% +47.71% |
| RowsBench | bench_map_on_10k | 2 | 3 | 130.222mb -0.00% | 72.105ms +1.07% | ±1.44% +20.07% |
| RowsBench | bench_merge_1k_on_10k | 2 | 3 | 93.565mb -0.00% | 1.617ms -10.46% | ±1.83% -30.57% |
| RowsBench | bench_partition_by_on_10k | 2 | 3 | 96.934mb -0.00% | 62.953ms -0.65% | ±0.49% -47.37% |
| RowsBench | bench_remove_on_10k | 2 | 3 | 94.618mb -0.00% | 3.690ms -9.24% | ±1.54% +16.60% |
| RowsBench | bench_sort_asc_on_1k | 2 | 3 | 92.096mb -0.00% | 40.222ms -2.92% | ±0.92% -52.07% |
| RowsBench | bench_sort_by_on_1k | 2 | 3 | 92.096mb -0.00% | 40.013ms -2.80% | ±0.14% -77.85% |
| RowsBench | bench_sort_desc_on_1k | 2 | 3 | 92.096mb -0.00% | 40.390ms -2.53% | ±1.61% +234.64% |
| RowsBench | bench_sort_entries_on_1k | 2 | 3 | 94.177mb -0.00% | 8.106ms -1.93% | ±1.05% -33.75% |
| RowsBench | bench_sort_on_1k | 2 | 3 | 91.927mb -0.00% | 29.981ms -1.95% | ±0.81% -60.87% |
| RowsBench | bench_take_1k_on_10k | 10 | 3 | 91.734mb -0.00% | 14.500μs -2.64% | ±0.56% +77.58% |
| RowsBench | bench_take_right_1k_on_10k | 10 | 3 | 91.734mb -0.00% | 17.467μs -5.44% | ±2.37% -27.21% |
| RowsBench | bench_unique_on_1k | 2 | 3 | 110.852mb -0.00% | 242.230ms +1.53% | ±0.37% -59.51% |
+-------------------+----------------------------+------+-----+------------------+------------------+-----------------+
Parquet Library+--------------------+---------------------------------+------+-----+----------------+-------------------+-----------------+
| benchmark | subject | revs | its | mem_peak | mode | rstdev |
+--------------------+---------------------------------+------+-----+----------------+-------------------+-----------------+
| ParquetReaderBench | bench_page_headers | 1 | 3 | 6.668mb -0.02% | 3.303s -1.17% | ±0.94% +106.86% |
| ParquetReaderBench | bench_read_metadata | 1 | 3 | 5.353mb -0.02% | 18.436ms -0.29% | ±0.36% -83.64% |
| ParquetReaderBench | bench_read_schema | 1 | 3 | 5.353mb -0.02% | 18.247ms -0.72% | ±0.85% +126.74% |
| ParquetReaderBench | bench_read_values_all_columns | 1 | 3 | 9.102mb -0.22% | 5.647s -28.11% | ±1.57% +234.40% |
| ParquetReaderBench | bench_read_values_single_column | 1 | 3 | 6.400mb -0.31% | 230.923ms -49.41% | ±0.54% -48.92% |
| ParquetReaderBench | bench_read_values_with_limit | 1 | 3 | 6.930mb -0.46% | 28.867ms -14.71% | ±1.14% +125.67% |
| ParquetWriterBench | bench_write_batch | 1 | 3 | 9.855mb -4.00% | 167.260ms -17.49% | ±1.06% +129.96% |
| ParquetWriterBench | bench_write_gzip | 1 | 3 | 9.816mb +0.01% | 179.745ms -0.85% | ±0.34% -15.79% |
| ParquetWriterBench | bench_write_row_by_row | 1 | 3 | 9.855mb -4.00% | 167.113ms -16.49% | ±0.66% +9.22% |
| ParquetWriterBench | bench_write_snappy | 1 | 3 | 9.855mb -4.00% | 166.687ms -17.10% | ±0.10% -41.88% |
| ParquetWriterBench | bench_write_uncompressed | 1 | 3 | 9.632mb +0.01% | 166.485ms +0.49% | ±1.75% +31.32% |
+--------------------+---------------------------------+------+-----+----------------+-------------------+-----------------+
|
norberttech
deleted the
1770-proposal-dx-improvements-for-exports-of-lists-of-structs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1770
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security