Resolve issues with Symfony dependencies#22
Open
djmattyg007 wants to merge 1 commit intoflint:masterfrom
Open
Conversation
This commit removes the dependency on the Symfony Config component. The only code other than getters that was actually being used was the constructors. In symfony 2, these were incredibly basic. In symfony 3, they perform some validation. This validation was causing a couple of "does not exist" tests to fail, as the Symfony Config module was performing these checks before the Lurker module, and throwing a different exception. Removing this dependency neatly solves this issue at the same time.
Author
|
Please note that until #24 is merged as well, the tests will continue to fail despite these improvements. |
|
Belated cheers @djmattyg007. I combined this with another/similar patch to remove |
Author
|
You should merge #24 too, as that should fix the issues you saw with inotify tests. Do you think you'd be able to open the issue tracker on your repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the dependency on the Symfony Config component. The
only code other than getters that was actually being used was the
constructors. In symfony 2, these were incredibly basic. In symfony 3,
they perform some validation.
This validation was causing a couple of "does not exist" tests to fail,
as the Symfony Config module was performing these checks before the
Lurker module, and throwing a different exception. Removing this
dependency neatly solves this issue at the same time.