Skip to content

Conversation

@ZanCorDX
Copy link
Collaborator

πŸ“ Summary

  • rbuilder cfg
  • Reth command line

πŸ’‘ Motivation and Context

Got in a fight with my wife so I would rather do this boring stuff than face her.

βœ… I have completed the following steps:

  • Run make lint
  • Run make test
  • Added tests (if applicable)

@ZanCorDX ZanCorDX requested a review from dvush as a code owner January 29, 2026 21:29
@claude
Copy link
Contributor

claude bot commented Jan 29, 2026

Claude finished @ZanCorDX's task in 1m 7s β€”β€” View job


Review Complete

I've reviewed the documentation changes in this PR. The changes are solid overall - they fix type mismatches in CONFIG.md, add documentation for new configuration options (optimistic_v3, bloxroute settings, etc.), and add helpful Reth command line examples to README.md.

Issues Found

I left one inline comment:

  • README.md:70 - The --rpc-max-connections 429496729 value appears extremely high (close to u32::MAX / 10). This may be a typo - typical values are around 4096 or 10000.

Summary of Changes

README.md:

  • Added Reth persistence threshold requirement
  • Added complete Reth command line example

docs/CONFIG.md:

  • Fixed type swaps for telemetry port/ip fields (port was incorrectly string, ip was incorrectly int)
  • Added new fields: otlp_env_name, root_hash_sparse_trie_version, adjust_finalized_blocks, system_recipient_allowlist, max_order_execution_duration_warning_us
  • Removed deprecated optimistic fields and added new optimistic_v3 configuration
  • Added new RelayConfig fields for bloxroute and optimistic v3
  • Fixed time_to_keep_mempool_txs_secs default from 1 to 60
  • Various typo fixes and formatting improvements

--ws \
--ws.addr 127.0.0.1 \
--ws.port 8545 \
--rpc-max-connections 429496729 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value 429496729 appears extremely high and looks like it may be a typo or placeholder. This is close to u32::MAX / 10. Is this intentional? Typically --rpc-max-connections would be set to something more reasonable like 4096 or 10000.

Suggested change
--rpc-max-connections 429496729 \
--rpc-max-connections 4096 \

@ZanCorDX ZanCorDX merged commit 7302972 into develop Jan 30, 2026
10 checks passed
@ZanCorDX ZanCorDX deleted the dx/update-docs branch January 30, 2026 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants