⚡ Bolt: Cache dynamically compiled RegExp in HTML extractor#56
⚡ Bolt: Cache dynamically compiled RegExp in HTML extractor#56
Conversation
Implemented a size-bounded LRU cache for RegExp objects in `htmlExtractor.ts`. 💡 What: Caches dynamically instantiated `RegExp` objects based on their pattern and flags using an LRUCache with a limit of 1000 items. Ensures `lastIndex = 0` on every usage. 🎯 Why: In `applyRegexProcessing`, a new `RegExp` was instantiated for every extracted field across every item during RSS feed parsing. This caused severe repeated compilation overhead inside a synchronous hot loop, blocking the event loop. The LRU cache ensures safe memory bounds against dynamic user patterns. 📊 Impact: Significantly reduces CPU load and GC overhead when parsing feeds with many items and selectors. 🔬 Measurement: Verify by parsing multiple RSS feeds with regex processing enabled; observe reduced parsing time and memory profiling. Co-authored-by: fillpit <90119466+fillpit@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Implemented a size-bounded LRU cache for RegExp objects in
htmlExtractor.ts.💡 What: Caches dynamically instantiated
RegExpobjects based on their pattern and flags using an LRUCache with a limit of 1000 items. EnsureslastIndex = 0on every usage. Also fixes a TypeScript warning inNpmPackageServiceby safely castingstdoutto string.🎯 Why: In
applyRegexProcessing, a newRegExpwas instantiated for every extracted field across every item during RSS feed parsing. This caused severe repeated compilation overhead inside a synchronous hot loop, blocking the event loop. The LRU cache ensures safe memory bounds against dynamic user patterns.📊 Impact: Significantly reduces CPU load and GC overhead when parsing feeds with many items and selectors.
🔬 Measurement: Verify by parsing multiple RSS feeds with regex processing enabled; observe reduced parsing time and memory profiling.
PR created automatically by Jules for task 7037397634980935995 started by @fillpit