Fix last SKIP control flow in scalar context #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes control flow propagation for
last SKIPthrough function calls in scalar context.Problem
Test #2 in skip_control_flow.t was failing:
The
last SKIPin inner2() wasn't exiting the SKIP block because the control flow marker wasn't being checked after outer2() returned.Solution
Added registry check in EmitBlock.java after each statement in simple labeled blocks (≤3 statements without loop constructs). The check:
Limited to simple blocks to avoid ASM VerifyError in complex code.
Results