fix: use the live api endpoint for map updating.#17
Merged
Conversation
arredond
approved these changes
Nov 19, 2024
Contributor
arredond
left a comment
There was a problem hiding this comment.
Thank you for the fix and also for providing a testing notebook! I'll add some more map-specific functionality to that in a followup PR.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on integrating the API.
I just noticed that in the API -- Map Update POST https://felt.com/api/v2/maps/{map_id}/update but in the Felt Python
update_map()leverages a PATCH (https://github.com/felt/felt-python/blob/main/felt_python/maps.py#L44) maps.pyExample:
Returns 200
Returns 404 - Route in python package.