next: Support use different color to indicate move blunder in variation#413
Merged
featurecat merged 2 commits intofeaturecat:nextfrom Nov 8, 2018
Merged
next: Support use different color to indicate move blunder in variation#413featurecat merged 2 commits intofeaturecat:nextfrom
featurecat merged 2 commits intofeaturecat:nextfrom
Conversation
e294275 to
ee120fe
Compare
ee120fe to
03118f4
Compare
Owner
|
LGTM |
Owner
|
By the way, you forgot to add the three config values to the config file. So I had to add them to get it to work. I fixed it. You should try deleting the config file as a test before making a PR, to see if a new feature still works. |
Owner
|
Actually apparently the node color is part of the theme. I'm not sure how I got it to work but it no longer works as of now. It's not part of the default theme which is problematic. |
Contributor
Author
|
You are right. Only these three options have no default value. I missed them. |
This was referenced Oct 30, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base on #412
Closes #389
Color node:

With comment node:

Config:
"blunder-winrate-thresholds": [-30,-20,-10,-5,5,10],
"blunder-node-colors":[[255,0,0],[0,255,0],[0,0,255],[255,255,0],[0,255,255],[255,0,255]],
"comment-node-color":[0,0,255,255],
Ctrl+T for toggle the node color with the comment
Press ‘Y' for switch node color display
default (show color) -> only black color -> only white color