fixed: Display latest stone for ghost dead stone#401
Merged
zsalch merged 3 commits intofeaturecat:nextfrom Nov 3, 2018
Merged
Conversation
| for (int j = 0; j < Board.BOARD_SIZE; j++) { | ||
| if (Lizzie.board.getData().stones[Board.getIndex(i, j)] != Stone.EMPTY) continue; | ||
| // Display latest stone for ghost dead stone | ||
| // if (Lizzie.board.getData().stones[Board.getIndex(i, j)] != Stone.EMPTY) continue; |
Contributor
There was a problem hiding this comment.
I would just remove the line and don't put a comment...
Contributor
Author
There was a problem hiding this comment.
Currently some test is ok, but has not more tests. I want to temporarily reserve it so that can suggest changes here when there is a problem.
Of course, I'm ok with remove it.
Contributor
There was a problem hiding this comment.
I see. So you propose to keep it commented out until we are sure that it doesn't break something else?
Contributor
Author
There was a problem hiding this comment.
Yes, this change can solve some problems, but it also changes the display of the stones. I think we should be cautious.
Contributor
Author
There was a problem hiding this comment.
I have committed a new change for fix the stone double shadow issue when branch
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #301
Display latest stone for ghost dead stone