Fixed some merge issues#393
Conversation
|
@zsalch LGTM |
| File startfolder = new File(config.optString("engine-start-location", ".")); | ||
| String networkFile = config.getString("network-file"); | ||
| // substitute in the weights file | ||
| engineCommand = engineCommand.replaceAll("%network-file", networkFile); |
There was a problem hiding this comment.
Specifically I mean the %network-file part. I can see the other parts were moved elsewhere so those seem fine.
There was a problem hiding this comment.
Seems redundant with what's done in the constructor.
|
Can your code review standards be a bit stronger? "Fixed some merge issues" is a bad PR description, and LGTM in response to that is not doing proper code review. |
|
@infinity0 Yeah, we're getting there... For context this project got to this state without any code review, tests or CI. This PR fixes stuff I introduced in 4315383 which was accidentally merge without being review (except for what you pointed out, which I overlooked). If you want to give us a hand feel to review whatever is in the PR queue! |
3 participants
Fixed some merge issues.