Allow file loading using CLI argument#326
Merged
featurecat merged 3 commits intofeaturecat:nextfrom Jul 14, 2018
Merged
Conversation
With this change it becomes possible to quickly load files from the CLI: java -jar Lizzie.jar /path/to/game.sgf Which is equivalant to - java -jar Lizzie.jar - press o - select /path/to/game.sgf using the java dialog
Owner
|
no it's good I prefer the 3. thank you. you also fixed the filename extension issue. does it still work with .gib files? |
Contributor
Author
I'm not sure what issue you are referring too, both .gib and .sgf work fine for me on master and next, and they can both be loaded from the CLI after this PR. The commit where I touched |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Leela 11 GUI from https://sjeng.org/leela.html has the same behavior, UNIX users might prefer that way of opening files over the Java dialog.
(I hope I'm not spamming too much with the 3 PRs, they are pretty unrelated so I figured I should open separate ones)