-
Notifications
You must be signed in to change notification settings - Fork 335
Description
Our transformers were originally designed to automatically select variables based on type. If the user passes a variable list, transformers will corroborate the type of those variables is suitable for the transformer.
If no variables of the suitable type are found, then the transformer raises an error and does not run.
Some users asked to allow transformers to continue even if they will not modify the dataframe. That means, allowing the transformers to "work" when the argument variables_ is an empty list. Instead of returning an error, the transformer now returns and empty list and it proceeds with fit and transform as usual, but basically both methods will do nothing.
I can see the benefit of this change: It enables users to create pipelines that can be used across datasets without breaking (and some specific examples highlighted in the issues below).
The downside: unaware users will think that they are modifying variables when they are not. It becomes more of a black box.
Thoughts?
Tagging you guys to gather your opinion if you have time :)
@glevv @ClaudioSalvatoreArcidiacono @ankitlade12 @david-cortes @sTomerG @MatheusHam