Removed shapeless from Scala 2, since it is fully replaced by Magnolia #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is not bin-compat, since the shapeless library is gone. This seems fine, since the removed values were implicits, and this will be a minor version bump |
Contributor
Author
|
@ayoub-benali please review |
ayoub-benali
approved these changes
Jul 19, 2024
Contributor
ayoub-benali
left a comment
ayoub-benali
left a comment
There was a problem hiding this comment.
Thanks for the contribution @soujiro32167 👍 No objection from me.
Any blocker @vlovgr ?
Contributor
|
This will have to wait until at least v2.0.0 since it breaks binary compatibility (it removes public definitions). There might still be library users who rely on having Shapeless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.