Skip to content
This repository was archived by the owner on Sep 28, 2023. It is now read-only.

Conversation

@tonyxiao
Copy link

Fixes issue #52

@ghost
Copy link

ghost commented May 31, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

@tonyxiao
Copy link
Author

@facebook-github-bot-4 Signed. :)

@ghost
Copy link

ghost commented May 31, 2016

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@ghost ghost added the CLA Signed The PR author has signed the Facebook CLA. label May 31, 2016
@frantic
Copy link
Contributor

frantic commented Jun 1, 2016

Would you mind running npm shrinkwrap --dev? We use it here to make sure the installation process is as reproducible as possible

@tonyxiao
Copy link
Author

tonyxiao commented Jun 2, 2016

Hmm I'm actually having trouble running npm shrinkwrap --dev on a fresh clone of f8app. Got ideas?

Tony:f8app (master)$ npm shrinkwrap --dev
npm ERR! Darwin 15.5.0
npm ERR! argv "/Users/Tony/.nvm/versions/node/v6.0.0/bin/node" "/Users/Tony/.nvm/versions/node/v6.0.0/bin/npm" "shrinkwrap" "--dev"
npm ERR! node v6.0.0
npm ERR! npm  v3.8.6

npm ERR! Problems were encountered
npm ERR! Please correct and try again.
npm ERR! invalid: have react-native-fbsdk@0.1.0-alpha.1 (expected: github:facebook/react-native-fbsdk#0.1.0-alpha.1) /Users/Tony/Code/tonyxiao/f8app/node_modules/react-native-fbsdk
npm ERR! invalid: have react-native-push-notification@1.0.2 (expected: github:frantic/react-native-push-notification#7142da7) /Users/Tony/Code/tonyxiao/f8app/node_modules/react-native-push-notification
npm ERR! invalid: have react-native-share@1.0.5 (expected: github:frantic/react-native-share#674df947b3) /Users/Tony/Code/tonyxiao/f8app/node_modules/react-native-share
npm ERR! extraneous: react-native-fbsdk@0.1.0-alpha.1 /Users/Tony/Code/tonyxiao/f8app/node_modules/react-native-fbsdk
npm ERR! extraneous: react-native-push-notification@1.0.2 /Users/Tony/Code/tonyxiao/f8app/node_modules/react-native-push-notification
npm ERR! extraneous: react-native-share@1.0.5 /Users/Tony/Code/tonyxiao/f8app/node_modules/react-native-share
npm ERR!
npm ERR! If you need help, you may report this error at:
npm ERR!     <https://github.com/npm/npm/issues>

npm ERR! Please include the following file with any support request:
npm ERR!     /Users/Tony/Code/tonyxiao/f8app/npm-debug.log

@tonyxiao
Copy link
Author

tonyxiao commented Jul 6, 2016

@frantic

@facebook-github-bot facebook-github-bot added the CLA Signed The PR author has signed the Facebook CLA. label Jul 12, 2016
@tonyxiao tonyxiao closed this Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed The PR author has signed the Facebook CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants