Fix pandas warnings about .ravel() #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandas was issuing FutureWarnings about calling `Series.ravel`, which could be fixed by calling `np.ravel()` instead, and a keyword argument of the groupby `.apply` changing the default to not include the index in the calculations (which is the right thing to do).
Member
Author
|
@santisoler the other warning about |
Member
Author
|
So the pandas warning about I think we should leave it as is and let pandas change their default when they want. It's not like we're doing something completely wrong since the tests pass with or without the new argument., |
leouieda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas was issuing FutureWarnings about calling
Series.ravel, which could be fixed by callingnp.ravel()instead, and a keyword argument of the groupby.applychanging the default to not include the index in the calculations (which is the right thing to do).