Bug fix in grid_to_table for wrong order of Dataset coords #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was using coords but thats an unordered dict and not necessarily the order of dimensions for the dataset.
The dims in the Dataset aren't ordered. Have to get them from the DataArrays themselves. Simplified some of the code for the rest of the function as well. Tests pass but need to check with different data arrays.
jessepisel
approved these changes
Feb 26, 2020
Contributor
jessepisel
left a comment
jessepisel
left a comment
There was a problem hiding this comment.
These changes look good, nice work @leouieda . The function is easier to read and is more explicit. Tests look reasonable, and all the builds are passing.
Member
Author
|
Thanks, @jessepisel! Merging this in now. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were relying on the order of the
coordsattribute of the data set tomeshgridthe coordinates. This is wrong because xarray takes the coordinate order fromdimsinstead, which is what we should also do. Took this chance to refactor the code and included a test that would have caught the bug.Reminders:
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rstand the base__init__.pyfile for the package.