Add SplineCV: a cross-validated Spline #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@santisoler finally had some time to finish this PR. Would you mind taking a look at it? I didn't edit the tutorial because I'm thinking that we should split the "Model Selection" tutorial into "Model Performance" and "Model Tuning". The first only focuses on running |
leouieda
added a commit
that referenced
this pull request
May 15, 2019
The previous model selection tutorial covered both scoring and automatic tuning. Separate into two tutorials "Evaluating Performance" and "Model Selection" so they are both shorter. Include a section in "Model Selection" about the new `SplineCV` class from #185.
5 tasks
Member
|
Sorry for missing the review! Great to have this merged! Nice work @leouieda! |
leouieda
added a commit
that referenced
this pull request
May 16, 2019
The previous model selection tutorial covered both scoring and automatic tuning. Separate into two tutorials "Evaluating Performance" and "Model Selection" so they are both shorter. Include a section in "Model Selection" about the new `SplineCV` class from #185.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SplineCVclass perfoms grid search cross-validation to auto-tune aSpline.It uses
cross_val_scoreto cross-validate and can be configured to run in parallelwith a
dask.distributed.Clientand take different scikit-learn splitters besidesKFold. Tested on the checkerboard function and add a gallery example using theTexas temperature data.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rstandverde/__init__.py.