Fix wrong coordinates for pixel-register and shape #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in
grid_coordinateswhen passingpixel_register=Trueandshapeinstead ofspacing. The returned coordinates had 1 too fewelements in each dimension (and the wrong values). This is because we
generate grid-line registered points first and then shift them to the
center of the pixels and drop the last point. This only works when
specifying
spacingbecause it will generate the right amount ofpoints. When
shapeis given, we need to first convert it to"grid-line" shape (with 1 extra point per dimension) before generating
coordinates.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rstandverde/__init__.py.