Skip to content

Conversation

@leouieda
Copy link
Member

verde.maxabs now uses the nan* version of numpy functions by default
to handle arrays with NaNs (like masked grids). This can be turned off
with an argument in case the not nan behavior is desired.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst and verde/__init__.py.
  • Write detailed docstrings for all functions/classes/methods.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

`verde.maxabs` now uses the `nan*` version of numpy functions by default
to handle arrays with NaNs (like masked grids). This can be turned off
with an argument in case the not `nan` behavior is desired.
@leouieda leouieda merged commit 5657506 into master Dec 12, 2018
@leouieda leouieda deleted the nanmaxabs branch December 12, 2018 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants