memorypool: make rc's api like std #48299
Merged
+340
−264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the constructor from
newtotry_new_in, and implsDerefandClone, to match how std's API works. This does a few things for us:newwhich we can reintroduce after this lands for using the system allocator instead of a memory pool. Having a singleRctype able to work with both kinds of memory sources is the optimal approach for supporting both in our linked list nodes (as opposed to wrapping two differentRctypes in anenumand using that for links).newandtry_new_in, ourRcbasically becomes a mirror of std while we wait for the allocator API to stabilize.