Establish reply.sent = true as a proper way to skip async/await handling

[mcollina]

Fixes #1330

To avoid conflicts, this is based on #1328, and it will need to be rebased once that lands.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows Code of conduct

[delvedor]

Great work! I left a couple of comments.

[delvedor]

Can you add a test with promises as well?

[mcollina]

This should be included in #1328

[mcollina]

I've rebased on top of master. PTAL.

[delvedor]

LGTM

[cemremengu]

LGTM

[allevo]

Can you run some benchmarks?

[mcollina]

sent-refactor:

$ autocannon -c 100 -d 5 -p 10 localhost:3000
Running 5s test @ http://localhost:3000
100 connections with 10 pipelining factor

┌─────────┬──────┬──────┬───────┬──────┬─────────┬─────────┬──────────┐
│ Stat    │ 2.5% │ 50%  │ 97.5% │ 99%  │ Avg     │ Stdev   │ Max      │
├─────────┼──────┼──────┼───────┼──────┼─────────┼─────────┼──────────┤
│ Latency │ 0 ms │ 0 ms │ 9 ms  │ 9 ms │ 1.19 ms │ 3.03 ms │ 39.73 ms │
└─────────┴──────┴──────┴───────┴──────┴─────────┴─────────┴──────────┘
┌───────────┬─────────┬─────────┬───────┬─────────┬─────────┬────────┬─────────┐
│ Stat      │ 1%      │ 2.5%    │ 50%   │ 97.5%   │ Avg     │ Stdev  │ Min     │
├───────────┼─────────┼─────────┼───────┼─────────┼─────────┼────────┼─────────┤
│ Req/Sec   │ 75775   │ 75775   │ 79231 │ 80319   │ 78854.4 │ 1637   │ 75774   │
├───────────┼─────────┼─────────┼───────┼─────────┼─────────┼────────┼─────────┤
│ Bytes/Sec │ 12.4 MB │ 12.4 MB │ 13 MB │ 13.2 MB │ 12.9 MB │ 267 kB │ 12.4 MB │
└───────────┴─────────┴─────────┴───────┴─────────┴─────────┴────────┴─────────┘

Req/Bytes counts sampled once per second.

394k requests in 5.04s, 64.7 MB read

master:

$ autocannon -c 100 -d 5 -p 10 localhost:3000
Running 5s test @ http://localhost:3000
100 connections with 10 pipelining factor

┌─────────┬──────┬──────┬───────┬──────┬─────────┬─────────┬──────────┐
│ Stat    │ 2.5% │ 50%  │ 97.5% │ 99%  │ Avg     │ Stdev   │ Max      │
├─────────┼──────┼──────┼───────┼──────┼─────────┼─────────┼──────────┤
│ Latency │ 0 ms │ 0 ms │ 9 ms  │ 9 ms │ 1.19 ms │ 3.03 ms │ 48.69 ms │
└─────────┴──────┴──────┴───────┴──────┴─────────┴─────────┴──────────┘
┌───────────┬─────────┬─────────┬─────────┬─────────┬─────────┬─────────┬─────────┐
│ Stat      │ 1%      │ 2.5%    │ 50%     │ 97.5%   │ Avg     │ Stdev   │ Min     │
├───────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┤
│ Req/Sec   │ 76543   │ 76543   │ 78783   │ 80703   │ 78726.4 │ 1324.42 │ 76510   │
├───────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┼─────────┤
│ Bytes/Sec │ 12.6 MB │ 12.6 MB │ 12.9 MB │ 13.2 MB │ 12.9 MB │ 217 kB  │ 12.5 MB │
└───────────┴─────────┴─────────┴─────────┴─────────┴─────────┴─────────┴─────────┘

Req/Bytes counts sampled once per second.

394k requests in 5.04s, 64.6 MB read

[allevo]

LGTM

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.