Skip to content

Conversation

@andfoy
Copy link

@andfoy andfoy commented May 5, 2025

What does this PR do?

See #1197

Before submitting

  • Did you have fun?
    • Make sure you had fun coding 🙃
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
    • N/A
  • Did you make sure to update the docs?
    • N/A
  • Did you write any new necessary tests?
    • N/A
  • Did you update the changelog? (if needed)
    • N/A

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 5, 2025
@rgommers
Copy link

rgommers commented May 7, 2025

The commenting out of pygit2 is for debug/workaround purposes only it looks like. pygit2 doesn't build under free-threading by default yet, but it's installable locally as outlined in libgit2/pygit2#1367. So better to do that, and not include other changes to handle it not being installed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants