Changed to only run reshard hook if all gradients computed #1166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
awgu
commented
Feb 29, 2024
| # On the first call, compute the actual nb_calls and buffer | ||
| # nb_calls = sum(torch._C._will_engine_execute_node(g) for g in grad_fns) # type: ignore[attr-defined] | ||
|
|
||
| # NOTE: To avoid resharding too early when microbatches share |
vivien-chu
approved these changes
Apr 1, 2024
awgu
merged commit 5faca97
into
facebookresearch:ngoyal_changes_for_pp_fp8_jiecaoyu_free_fp16_shard
chrisxcai
pushed a commit
that referenced
this pull request
May 15, 2024
* Changed to only run reshard hook if all gradients computed * Fix decreasing it/s with multi-grad hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue).
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.