Skip to content

Preserve inline comments#344

Merged
maggiemoss merged 6 commits intofacebook:mainfrom
maggiemoss:preserve-inline-comments
Jan 5, 2026
Merged

Preserve inline comments#344
maggiemoss merged 6 commits intofacebook:mainfrom
maggiemoss:preserve-inline-comments

Conversation

@maggiemoss
Copy link
Contributor

While working with usort in the pytorch codebase, the formatting does not allow us to reformat code with a type error that exists in an import, since the suppression comment will get moved.

This PR attempts to add that as a configuration option to usort to unblock rolling out pyrefly to additional files in pytorch.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 5, 2026
@maggiemoss maggiemoss requested review from bowiechen and oulgen January 5, 2026 21:23
Copy link
Contributor

@bowiechen bowiechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@maggiemoss maggiemoss merged commit 568ceba into facebook:main Jan 5, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants