[WIP] React Native: Turn HostComponent into an EventEmitter#23278

Closed

JoshuaGross wants to merge 27 commits intofacebook:mainfrom

JoshuaGross:jgross-hostcomponent-eventemitter

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[WIP] React Native: Turn HostComponent into an EventEmitter#23278

[WIP] React Native: Turn HostComponent into an EventEmitter#23278
JoshuaGross wants to merge 27 commits intofacebook:mainfrom
JoshuaGross:jgross-hostcomponent-eventemitter

Commits on Feb 11, 2022

Turn HostComponent into an EventEmitter

_eventListeners is null by default to save on memory/perf

make listeners nullable

Commits on Feb 12, 2022

New mechanism for 'once'

Commits on Feb 14, 2022

fix typo, add comments

CustomEvent should be typed in react, but implemented in RN repo

Commits on Feb 18, 2022

Handle CustomEvent in ReactNativeBridgeEventPlugin

getEventListener returns an array of functions instead of Function | null

Commits on Feb 24, 2022

Send data back and forth between Event <> SyntheticEvent in a way that supports the RN Event polyfill

typo

fix null deref

fix dispatch / listener code to accept 0 or more listeners and handle 2+ listeners

fix another site where insts.length needs to == listeners.length

getListener -> getListeners

fix flow

missing files

prettier

fix lints, clean up

initialize listeners to null, only create empty array if there is a listener to add to it - to avoid creating empty arrays that aren't ever used in a hot path

initialize listeners to null, only create empty array if there is a listener to add to it - to avoid creating empty arrays that aren't ever used in a hot path

var in for loop to make ci happy?

yarn replace-fork

turn for loop into forEach

yarn prettier-all

attempt to provide a working CustomEvent jest mock so that tests can run

remove console.log

Commits on Feb 25, 2022

fix capture phase registration

[WIP] React Native: Turn HostComponent into an EventEmitter#23278JoshuaGross wants to merge 27 commits intofacebook:mainfacebook/react:mainfrom JoshuaGross:jgross-hostcomponent-eventemitterJoshuaGross/react:jgross-hostcomponent-eventemitterCopy head branch name to clipboard

Commits

Commits on Feb 11, 2022

Commits on Feb 12, 2022

Commits on Feb 14, 2022

Commits on Feb 18, 2022

Commits on Feb 24, 2022

Commits on Feb 25, 2022

[WIP] React Native: Turn HostComponent into an EventEmitter#23278
JoshuaGross wants to merge 27 commits intofacebook:mainfrom
JoshuaGross:jgross-hostcomponent-eventemitter