Use Java version of Google Closure Compiler#12800
Merged
gaearon merged 13 commits intofacebook:masterfrom May 14, 2018
Merged
Conversation
bvaughn
approved these changes
May 14, 2018
Contributor
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
I skimmed over the CircleCI and AppVeyor parts b'c I don't know about them. But overall this looks okay. 😄 Exciting speed and memory gains.
| }); | ||
| console.error(frame); | ||
| } else { | ||
| } else if (error.codeFrame) { |
Contributor
There was a problem hiding this comment.
Should we add an else here with something (e.g. "Unknown error")?
Collaborator
Author
There was a problem hiding this comment.
We already print the error message itself earlier so these are additive.
Collaborator
Author
|
CircleCI part works (I tested), as for AppVeyor we'll have to see because it only runs on master. |
Collaborator
|
Should we file a bug with Closure? |
Collaborator
Author
|
Nah, they're aware JS version is vastly inferior and were actually surprised it was usable to us. 😄 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was actually done by @trueadm, I just did a minor cleanup on top while he's away from keyboard.
The JS version of GCC is already too slow, and its memory usage is getting worse as we throw more inlinable code at it. Without this change, we can't land #12792 (7% prod build size reduction) because it eats over 16GB of RAM and never completes. For comparison, the Java version memory use peaks under 300 MB and completes in a few seconds. Luckily it's nicely packaged under a launcher distributed on npm so it's not a pain to integrate.
This change, however, means you can't
yarn buildwithout Java installed. I can imagine this being annoying for open source contributors. I don't see better options though.