Bump expiration for interactive updates to 150ms in production#12599
Merged
flarnie merged 2 commits intofacebook:masterfrom Apr 11, 2018
Merged
Bump expiration for interactive updates to 150ms in production#12599flarnie merged 2 commits intofacebook:masterfrom
flarnie merged 2 commits intofacebook:masterfrom
Conversation
**what is the change?:** Changes the expiration deadline from 500ms to 150ms, only in production. In development it will still be 500ms. I'm thinking we may want to change the 'bucket size' too, will look into that a bit. **why make this change?:** We need to ensure interactions are responsive enough in order to gather more test data on async. mode. **test plan:** No tests failed - where shall we add a test for this?
acdlite
approved these changes
Apr 10, 2018
sebmarkbage
reviewed
Apr 10, 2018
| const expirationMs = 500; | ||
| let expirationMs; | ||
| if (__DEV__) { | ||
| // Should complete within ~500ms. 600ms max. |
Contributor
There was a problem hiding this comment.
Would be good to document the rationale here. It's because relying on expiration is an indicator that you could've been doing better and you should see that opportunity during dev.
In prod, it's better to opt for slightly better UX if you fail.
Contributor
Author
There was a problem hiding this comment.
Thanks - will update the comment.
Contributor
Author
|
It looks like the 'bucket size' just allows us to 'bucket' updates into expiration times, so if we have the following times: Then the bucketing just groups them like so: That should work the same way whether they expire in 150ms or 500ms. I also don't think we need a test for this right now - ideally we are not relying too much on expiration. |
This was referenced Apr 17, 2018
This was referenced Apr 19, 2018
rhagigi
pushed a commit
to rhagigi/react
that referenced
this pull request
Apr 19, 2018
…ook#12599) * Bump expiration for interactive updates to 150ms in production **what is the change?:** Changes the expiration deadline from 500ms to 150ms, only in production. In development it will still be 500ms. I'm thinking we may want to change the 'bucket size' too, will look into that a bit. **why make this change?:** We need to ensure interactions are responsive enough in order to gather more test data on async. mode. **test plan:** No tests failed - where shall we add a test for this? * Add comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what is the change?:
Changes the expiration deadline from 500ms to 150ms, only in production.
In development it will still be 500ms.
I'm thinking we may want to change the 'bucket size' too, will look into
that a bit.
why make this change?:
We need to ensure interactions are responsive enough in order to gather
more test data on async. mode.
Hoping to land and sync this into FB asap.
test plan:
No tests failed - where shall we add a test for this?