Update ReactElement.js#11767
Closed
Gregoirevda wants to merge 1 commit intofacebook:masterfrom
Gregoirevda:patch-3
Closed
Update ReactElement.js#11767Gregoirevda wants to merge 1 commit intofacebook:masterfrom Gregoirevda:patch-3
Gregoirevda wants to merge 1 commit intofacebook:masterfrom
Gregoirevda:patch-3
Conversation
As far as I know, only `React` global has `createElement` property. So, if this check is made: https://github.com/facebook/react/blob/master/packages/react/src/React.js#L43 there shouldn't be any `__DEV__` checks in the 'non validation' file?
Contributor
|
Hey there. So all validations are removed in the production copy via dead code elimination, so there is no worry about warnings slipping into the prod build. This change however, will remove those warnings for both dev and prod builds which is not what we want. Notice that ReactElementValidator imports ReactElement, so the warnings are added on top of what's already in ReactElement |
Contributor
Author
|
Oh ok! It's not |
This was referenced Dec 18, 2020
This was referenced Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I know, only
Reactglobal hascreateElementproperty. So, if this check is made: https://github.com/facebook/react/blob/master/packages/react/src/React.js#L43 there shouldn't be any__DEV__checks in the 'non validation' file?Before submitting a pull request, please make sure the following is done:
master.yarnin the repository root.yarn test). Tip:yarn test --watch TestNameis helpful in development.yarn test-prodto test in the production environment. It supports the same options asyarn test.yarn prettier).yarn lint). Tip:yarn lincto only check changed files.yarn flow).Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html