Skip to content

Conversation

@revi
Copy link
Contributor

@revi revi commented May 23, 2024

Update more translation since last commit (2022)

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Update Korean translation.

Test Plan

Build and pray npm will build correctly? /joke

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

Update more translation since last commit (2022)

Signed-off-by: Yongmin Hong <revi@omglol.email>
@revi revi requested review from Josh-Cena and slorber as code owners May 23, 2024 10:36
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 23, 2024
@netlify
Copy link

netlify bot commented May 23, 2024

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f578011
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/664f1c2ec5c16100083cbc1c
😎 Deploy Preview https://deploy-preview-10165--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 67 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 69 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 67 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 69 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 74 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber changed the title feat(theme-translation): add more Korean (ko) translation fix(theme-translation): add missing Korean (ko) theme translations May 23, 2024
@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label May 23, 2024
@slorber
Copy link
Collaborator

slorber commented May 23, 2024

Thanks 👍

@slorber slorber merged commit aab332c into facebook:main May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants