Skip to content

Conversation

@dmorgan-fa
Copy link
Contributor

@dmorgan-fa dmorgan-fa commented Jun 22, 2023

What

Previously we added actionlint workflows to lots of repos:

They trigger on every push to a PR branch, so most of the time this is unnecessary, as workflows are rarely updated. Really we only need to trigger actionlint when workflows are changed.

We're now looking to use org-wide reusable workflows that can be updated in one central place.

Note!

The org-wide shared workflow is for private repos only.
We're using this repo as the public mirror for the private workflow since only a few repos are public and require this workflow.
In future we might look to create a shared-workflows-public repo if necessary.

Dev-P ticket

@dmorgan-fa dmorgan-fa requested a review from dgholz June 23, 2023 10:34
@dmorgan-fa dmorgan-fa marked this pull request as ready for review June 23, 2023 10:34
@dmorgan-fa dmorgan-fa marked this pull request as draft June 23, 2023 11:00
@dmorgan-fa dmorgan-fa removed the request for review from dgholz June 23, 2023 11:00
 # What
Previously we added `actionlint` workflows to lots of repos:
- fac/dev-platform#314

They trigger on every push to a PR branch, so most of the time this is unnecessary, as workflows are rarely updated. Really we only need to trigger `actionlint` when workflows are changed.

We're now looking to use org-wide reusable workflows that can be updated in one central place.

 # Note!
The org-wide shared workflow is for private repos only.
We're using this repo as the public mirror for the private workflow since only a few repos are public and require this workflow.
In future we might look to create a `shared-workflows-public` repo if necessary.

Dev-P ticket
 - fac/dev-platform#1002
@dmorgan-fa dmorgan-fa force-pushed the org-wide-reusable-actionlint-workflow branch from 91bcd2b to b91b785 Compare June 23, 2023 13:50
@dmorgan-fa dmorgan-fa requested a review from dgholz June 23, 2023 13:52
@dmorgan-fa dmorgan-fa marked this pull request as ready for review June 23, 2023 13:52
@dgholz dgholz merged commit 186fcc3 into master Jun 23, 2023
@dgholz dgholz deleted the org-wide-reusable-actionlint-workflow branch June 23, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants