check-exercises: Output progress dot when DENYWARNINGS #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, Travis may assume we're hung if we don't produce output in 10+ minutes. Normally we don't think checking all exercises takes this long, but this prepares for the future and prevents spurious failures in instances when outside circumstances cause slowness. This approach was suggested in response to such a failure in #435 (comment)
ijanos
approved these changes
Mar 4, 2018
coriolinus
approved these changes
Mar 4, 2018
petertseng
commented
Mar 5, 2018
| ./bin/test-exercise $directory --quiet --no-run | ||
| # Output a progress dot; otherwise Travis may assume we're hung, | ||
| # if we don't produce output in > 10 mins. | ||
| echo -n '.' |
Member
Author
There was a problem hiding this comment.
nope, bad, now $? will always be 0. Move this before bin/test-exercise please.
petertseng
added a commit
that referenced
this pull request
Mar 5, 2018
Notice that below `test-exercise` there is a check of `$?`. This means nothing should come after `test-exercise`. If we fail to do this, warnings will never cause the build to fail (as we would like them to), because the `$?` is examining the exit code of `echo`. We need to move the `echo` (progress dot) that we added in #446 a3a7b16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, Travis may assume we're hung if we don't produce output in
10+ minutes. Normally we don't think checking all exercises takes this
long, but this prepares for the future and prevents spurious failures in
instances when outside circumstances cause slowness.
This approach was suggested in response to such a failure in
#435 (comment)