Skip to content

Fix variable used in TestSummaryInfo.has_all #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
refuel-code-135 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix variable used in TestSummaryInfo.has_all #1747

refuel-code-135 wants to merge 1 commit into from
+1 −1

Conversation

@refuel-code-135
Copy link

@refuel-code-135 refuel-code-135 commented Nov 21, 2025 •
edited
Loading

I think this is just a small mistake.
The intended field to check should be self.all_column.

    @property
    def has_all(self):
        return self.any_column is not None
✅      return self.all_column is not None

    @property
    def has_any(self):
        return self.any_column is not None

@refuel-code-135
A variable mistake.
9718eaa 
I believe this is simply a minor typo.
The intended field to check should be self.all_column.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@refuel-code-135