Enhanced get_binned_data Function with Flexible Fill Methods and Dynamic Scaling #1660
+32
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2025
Contributor
Author
|
If this is still acceptable I can probably explore on why the tests are failing for different python versions... What do you think? @emeli-dral |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #334
This PR rebases and enhances the original proposal by #1278 to dynamically compute
fill_zeroesinget_binned_data().Key contributions from original PR #334:
dynamic_scaleThis PR preserves all that functionality, resolves merge conflicts, and ensures compliance with the current codebase and linter requirements.
Core Logic and code by - @boemer00