-
Notifications
You must be signed in to change notification settings - Fork 84
Deprecate the old request manager #7168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryThis PR successfully deprecates the old table-based request manager and replaces it with the new list-based implementation. The change removes ~900 lines of code by deleting obsolete components, tests, and the Key Changes:
Minor Issue:
Confidence Score: 4/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
clients/admin-ui/src/features/common/nav/routes.ts, line 45 (link)style: Unused route constant - should be deleted since
/new-privacy-requestspage no longer exists
13 files reviewed, 1 comment
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Always nice to see a bunch of old code removal
…e-the-old-request-manager
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
…etter-debounce-to-text-input-on-filters-bar
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
Ticket ENG-2133
Description Of Changes
Delete old request manager page. Replace with new list based request manager.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works