Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 19, 2025

Ticket ENG-2133

Description Of Changes

Delete old request manager page. Replace with new list based request manager.

Code Changes

  • Replaced old request manager page with new one
  • Deleted components only referenced by the old request manager
  • Removed outdated cypress tests (new ones were added in a different file)
  • Removed the feature flag for the new request manager

Steps to Confirm

  1. Open preview link
  2. Check that Privacy requests > Request manager now shows the new request manager
  3. Try navigating to a detail page and back to the list page

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Dec 19, 2025 8:53pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Dec 19, 2025 8:53pm

@lucanovera lucanovera changed the base branch from main to ENG-2064-FE-Add-better-debounce-to-text-input-on-filters-bar December 19, 2025 15:41
@lucanovera lucanovera marked this pull request as ready for review December 19, 2025 15:48
@lucanovera lucanovera requested a review from a team as a code owner December 19, 2025 15:48
@lucanovera lucanovera requested review from speaker-ender and removed request for a team December 19, 2025 15:48
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 19, 2025

Greptile Summary

This PR successfully deprecates the old table-based request manager and replaces it with the new list-based implementation. The change removes ~900 lines of code by deleting obsolete components, tests, and the privacyRequestV2 feature flag.

Key Changes:

  • Moved new request manager from /new-privacy-requests to /privacy-requests route
  • Removed feature flag gating - new implementation is now the default
  • Deleted old components: PrivacyRequestsContainer, RequestTable, RequestTableColumns, RequestTableFilterModal, and related hooks
  • Removed outdated Cypress tests for table-based UI (detail page tests remain)
  • Updated navigation config to remove duplicate nav item

Minor Issue:

  • The PRIVACY_REQUESTS_ROUTE_NEW constant in routes.ts should be removed as it's no longer used

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it's primarily a code deletion PR that removes deprecated code
  • Score reflects thorough cleanup of old code and proper feature flag removal. One unused route constant remains but doesn't affect functionality. The new implementation was already tested in previous PRs.
  • Pay attention to routes.ts for the unused constant cleanup

Important Files Changed

Filename Overview
clients/admin-ui/src/pages/privacy-requests/index.tsx Replaced old implementation with new list-based dashboard, imports moved from old container to new components
clients/admin-ui/src/flags.json Removed privacyRequestV2 feature flag as new implementation is now default
clients/admin-ui/src/features/common/nav/nav-config.tsx Removed "Request manager (new)" nav item that used feature flag and separate route
clients/admin-ui/cypress/e2e/privacy-requests.cy.ts Removed old table-based tests (approve, deny, delete from list); detail page tests remain intact

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. clients/admin-ui/src/features/common/nav/routes.ts, line 45 (link)

    style: Unused route constant - should be deleted since /new-privacy-requests page no longer exists

13 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Always nice to see a bunch of old code removal

lucanovera and others added 5 commits December 19, 2025 14:19
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
lucanovera and others added 3 commits December 19, 2025 16:35
Co-authored-by: Jason Gill <jason.gill@ethyca.com>
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
…s-bar' of github.com:ethyca/fides into ENG-2133-Deprecate-the-old-request-manager
Base automatically changed from ENG-2064-FE-Add-better-debounce-to-text-input-on-filters-bar to main December 19, 2025 21:35
@lucanovera lucanovera added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 440fc97 Dec 19, 2025
44 checks passed
@lucanovera lucanovera deleted the ENG-2133-Deprecate-the-old-request-manager branch December 19, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants