Skip to content

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 19, 2025

Ticket ENG-1626

Description Of Changes

Adds cypress test coverage for the new privacy request. There will be a followup PR that adds more unit tests as well.
The tests here aim to do a general testing on the page on rendering and the main action, but intentionally doesn't cover everything. eg I added a test for a search filter and a dropdown filter, but not all filters. the unit tests instead will test every single filter.

Here's the list of tests added:

New Privacy Requests

The requests dashboard

  • shows list of requests with status badges
  • shows pagination controls
  • search filter works
  • status filter works
  • reload button refetches data
  • export button triggers download

Request list items

  • clicking a request navigates to details page
  • approve action works from list item
  • reject action works from list item

Bulk actions

  • can select multiple requests
  • bulk approve works
  • bulk actions disabled when nothing selected

Tab navigation

  • can switch to Manual Tasks tab
  • tab persists in URL

privacy request creation

showing button depending on role

  • shows the option to create when permitted
  • does not show the option to create when not permitted
  • shows the option to create for approver role

submitting a request

  • opens the modal
  • shows configured fields and values
  • can submit a privacy request

Code Changes

  • Added tests in a new folder

Steps to Confirm

  1. CI passes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Dec 19, 2025 5:48am
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Dec 19, 2025 5:48am

@lucanovera lucanovera marked this pull request as ready for review December 19, 2025 05:18
@lucanovera lucanovera requested a review from a team as a code owner December 19, 2025 05:18
@lucanovera lucanovera requested review from gilluminate and removed request for a team December 19, 2025 05:18
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 19, 2025

Greptile Summary

Adds comprehensive Cypress test coverage for the new request manager page, testing dashboard rendering, filters, pagination, bulk actions, tab navigation, permissions, and request creation.

Key Changes:

  • Dashboard tests verify status badges, pagination, search/status filters, reload and export functionality
  • Request list item tests cover navigation and approve/reject actions
  • Bulk action tests validate multi-select and batch operations
  • Tab navigation tests ensure URL persistence
  • Permission tests verify role-based button visibility
  • Request creation tests validate modal flow and form submission

Minor Issue:

  • Contains duplicate test coverage for submit button visibility across two test blocks (lines 262-281 and 290-309)

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk
  • Well-structured test file with comprehensive coverage of the new request manager page. Only minor style issue with duplicate test coverage. Tests follow established Cypress patterns and properly use test IDs and fixtures.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/cypress/e2e/request-manager/new-request-manager-list-page.cy.ts Comprehensive Cypress test suite for new request manager page with minor duplicate test coverage

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@lucanovera lucanovera added this pull request to the merge queue Dec 19, 2025
Merged via the queue into main with commit 7ca30c6 Dec 19, 2025
47 checks passed
@lucanovera lucanovera deleted the ENG-1626-Add-cypress-test-coverage-for-new-privacy-request-ui branch December 19, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants