Xfail old Okta tests

[johnewart]

Ticket N/A

Description Of Changes

xfail old Okta tests

Code Changes

• Added xfail decorators to old okta tests

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Review	Updated (UTC)
fides-plus-nightly	Ignored	Preview	Dec 18, 2025 9:56pm
fides-privacy-center	Ignored		Dec 18, 2025 9:56pm

[greptile-apps]

Greptile Summary

Marks old Okta test classes as expected to fail using @pytest.mark.xfail decorator following the recent Okta OAuth2 implementation changes.

Major changes:

• Added @pytest.mark.xfail(reason="Old Okta tests") to TestSystemOkta class in tests/ctl/core/test_system.py:331
• Added @pytest.mark.xfail(reason="Old Okta tests") to TestOktaConnector class in tests/ops/integration_tests/test_connection_configuration_integration.py:1622
• Commented out credential check in test_scan_system_okta_success but not in other test methods

Issues found:

• Inconsistent handling of credential checks within TestSystemOkta - one method has the check commented out while another keeps it active

Confidence Score: 3/5

• This PR is safe to merge but has an inconsistency that should be addressed
• The changes correctly mark old Okta tests as xfail, which is appropriate after the OAuth2 refactor. However, there's an inconsistency in credential check handling within the same test class - one test method has the check commented out while another keeps it active. This inconsistency could lead to confusion and should be standardized.
• tests/ctl/core/test_system.py needs attention to resolve inconsistent credential check handling

Important Files Changed

Filename	Overview
tests/ctl/core/test_system.py	Added @pytest.mark.xfail to TestSystemOkta class but inconsistently commented out credential checks in only one test method
tests/ops/integration_tests/test_connection_configuration_integration.py	Added @pytest.mark.xfail to TestOktaConnector class, marking it as expected to fail

[greptile-apps]

Additional Comments (1)

1. tests/ctl/core/test_system.py, line 339-340 (link)

   logic: inconsistent credential check handling - test_generate_system_okta keeps the check while test_scan_system_okta_success comments it out

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.17%. Comparing base (f8da0a0) to head (b9794cf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #7158   +/-   ##
=======================================
  Coverage   87.17%   87.17%           
=======================================
  Files         534      534           
  Lines       35312    35312           
  Branches     4113     4113           
=======================================
  Hits        30783    30783           
  Misses       3638     3638           
  Partials      891      891           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.