Skip to content

Conversation

@jpople
Copy link
Contributor

@jpople jpople commented Dec 17, 2025

Ticket ENG-2021

Description Of Changes

Adds a component for handling page-level errors and a sample page to the Developer nav.

Screenshot 2025-12-16 at 23 16 36

Will follow up with a PR to add this across the UI where appropriate.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@jpople jpople requested a review from a team as a code owner December 17, 2025 05:19
@jpople jpople requested review from speaker-ender and removed request for a team December 17, 2025 05:19
@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Dec 17, 2025 6:35pm
1 Skipped Deployment
Project Deployment Review Updated (UTC)
fides-privacy-center Ignored Ignored Dec 17, 2025 6:35pm

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 17, 2025

Greptile Summary

Added a reusable page-level error component (ErrorPage) with visual error images (404, 500, generic) and a demo page in the Developer nav. The component displays error status, message, detailed error data with clipboard copy functionality, and customizable action buttons.

Key changes:

  • Created ErrorPage component using Ant Design Result component with custom error images
  • Created ErrorImage component to display different SVG illustrations based on error status
  • Added three SVG error illustrations (404, 500, generic)
  • Added demo page at /poc/error accessible via Developer nav (dev-only)
  • Removed TODO comment from TaxonomyPageContent.tsx

Issues found:

  • Critical bug: ErrorImage.tsx references unknown.svg but the actual file created is generic.svg - this will cause a broken image in production

Confidence Score: 3/5

  • This PR has one critical bug that will cause broken images but is otherwise safe
  • The implementation follows existing patterns and is well-structured, but contains a critical filename mismatch bug in ErrorImage.tsx that references unknown.svg instead of generic.svg. This will result in broken images when displaying generic errors. The bug must be fixed before merging.
  • Pay close attention to clients/admin-ui/src/features/common/errors/ErrorImage.tsx - fix the filename mismatch before merging

Important Files Changed

Filename Overview
clients/admin-ui/src/features/common/errors/ErrorImage.tsx Added component to display error images based on status code. Critical bug: references unknown.svg but file is named generic.svg
clients/admin-ui/src/features/common/errors/ErrorPage.tsx Added reusable error page component with image, message, and action buttons. Clean implementation following existing patterns
clients/admin-ui/src/pages/poc/error.tsx Added demo page for testing error component. Follows existing POC patterns and is dev-only

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question but otherwise looks good!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we are going with multiple svgs vs having a dynamic svg component to change the text?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplicity, mostly? It is a bit redundant but it seemed easier to work with than doing a dynamic one, especially since I don't necessarily expect this to need to be expanded.

Merged via the queue into main with commit cd96f3a Dec 17, 2025
47 checks passed
@jpople jpople deleted the jpople/eng-2021/page-level-errors branch December 17, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants