-
Notifications
You must be signed in to change notification settings - Fork 84
Add page-level error component #7144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile SummaryAdded a reusable page-level error component ( Key changes:
Issues found:
Confidence Score: 3/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, 2 comments
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question but otherwise looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we are going with multiple svgs vs having a dynamic svg component to change the text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplicity, mostly? It is a bit redundant but it seemed easier to work with than doing a dynamic one, especially since I don't necessarily expect this to need to be expanded.
Ticket ENG-2021
Description Of Changes
Adds a component for handling page-level errors and a sample page to the Developer nav.
Will follow up with a PR to add this across the UI where appropriate.
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works