-
Notifications
You must be signed in to change notification settings - Fork 84
Add sorting to new privacy request dashboard #7138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Greptile OverviewGreptile SummaryAdds sorting functionality to the privacy request dashboard, allowing users to sort by time received or days left in ascending/descending order. The sort state is managed via URL query parameters and properly integrated with the existing filter system. Critical Issue Found:
Implementation Details:
Confidence Score: 1/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 files reviewed, 1 comment
clients/admin-ui/src/features/privacy-requests/dashboard/PrivacyRequestSortMenu.tsx
Show resolved
Hide resolved
…b.com/ethyca/fides into jpople/eng-1760/sort-privacy-requests
speaker-ender
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor code and UX requests but looks good overall!
clients/admin-ui/src/features/privacy-requests/dashboard/PrivacyRequestSortMenu.tsx
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| return ( | ||
| <AntDropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use a Dropdown component instead of a Select?
It would be nice to see the selected sort option without having to open the dropdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I think I just tunnel-visioned on the wording on the ticket which suggested a dropdown. I've updated to a Select.
| setSortState: (sortState: SortParams) => void; | ||
| } | ||
|
|
||
| enum SortOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required in this PR, but I think in the future we should have a standard for sorting.
An enum for asc and desc could be reused, and then it could be paired with a list/table item attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, agreed-- this felt a bit janky as I was putting it together. We do have a reusable enum for asc and desc already but this exact pattern with a select with two options for each attribute is new for Lists, since tables are generally sorted from the table header. Would be good to get a more robust option.
Ticket ENG-1760
Description Of Changes
Adds a sorting menu to the new privacy request manager.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works