ENG-1532: Add GPC translation fields - Frontend/UI #7137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add 5 GPC columns to ExperienceTranslationBase: gpc_label, gpc_description, gpc_title, gpc_status_applied_label, gpc_status_overridden_label - Migration populates fields from existing fides-js locale JSON files
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Required for fides_db_scan CI check to pass.
thabofletcher
force-pushed
the
ENG-1532-gpc-dynamic-strings-ui
branch
2 times, most recently
from
3c46603 to
e4608a2
Compare
Migration now populates GPC fields for all existing translations, using language-specific values from a hardcoded dict.
thabofletcher
force-pushed
the
ENG-1532-gpc-dynamic-strings-ui
branch
from
8e84566 to
914b1c0
Compare
Admin UI: - Add GPC text section to translation form for BANNER_AND_MODAL and MODAL types - Update TypeScript types for GPC fields - Add validation for GPC fields fides-js: - Update i18n-utils to extract GPC fields from experience config - Update GpcBadge and ConsentContent to use dynamic strings with static fallback
GPC fields were being stripped from the preview because they weren't in the defaultTranslation object used by translationOrDefault()
Removes the awkward dropdown/collapse and displays GPC fields inline like the other translation fields.
thabofletcher
force-pushed
the
ENG-1532-gpc-dynamic-strings-ui
branch
from
914b1c0 to
0a3ce61
Compare
thabofletcher
requested review from
lucanovera
and removed request for
a team
Base automatically changed from
ENG-1532-gpc-dynamic-strings-migration
to
main
December 17, 2025 20:11
thabofletcher
force-pushed
the
ENG-1532-gpc-dynamic-strings-ui
branch
from
1c97b1f to
56d2e14
Compare
Contributor
Author
|
Removed backend review - some migration code snuck in but that has been cleaned up, this is all FE code now |
Contributor
Author
|
I can't really cut down on the number of files that need to be changed - its is required to make the change and have all the tests pass. |
Contributor
Author
lucanovera
approved these changes
Dec 19, 2025
Contributor
lucanovera
left a comment
lucanovera
left a comment
There was a problem hiding this comment.
Followed steps to reproduce, everything works correctly, even tried it with a different language. Code changes look good. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-1532
Description Of Changes
Adds Global Privacy Control (GPC) translation fields to the Admin UI privacy experience configuration and updates fides-js to use dynamic translations from the database with static fallbacks.
This allows customers to customize all GPC-related text that appears in consent banners and modals, including the GPC label, title, description, and status labels.
Code Changes
Migrations and other changes have already been committed to main on fides and fidesplus, this is only the UI portion of the feature.
Admin UI:
ExperienceTranslation,ExperienceTranslationCreate) to include GPC fieldstranslations-form-validations.tshelpers.tsfides-js:
i18n-utils.tsto extract GPC fields from experience config translationsGpcBadge.tsxto use dynamicexp.gpc_labelandexp.gpc_status_*_labelwith static fallbacksConsentContent.tsxto use dynamicexp.gpc_titleandexp.gpc_descriptionwith static fallbacksconsent-types.tsto include GPC fields inExperienceConfigTranslationtypeSteps to Confirm
Run fidesplus (slim on main branch) pointing to fides on this branch, then:
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works